Repository navigation
Validate remaining FP16 instruction features - #8979
Merged
tlively merged 1 commit intoAug 26, 2026
Merged
Conversation
The originally reported SIMDTernary case was fixed by WebAssembly#8403. This adds missing FP16 feature validation for seven unary conversion ops and f32.load_f16/f32.store_f16 when --enable-fp16 is not set. Fixes WebAssembly#8313. Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
ANAMASGARD
requested review from
stevenfontanella
and removed request for
a team
August 7, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8313
Summary
visitUnaryf32.load_f16andf32.store_f16invisitLoad/visitStoreforeachThe SIMDTernary madd/nmadd case from the original report was fixed by Validate SIMDTernary features #8403; this PR closes the remaining identifiable FP16 validation gaps found by audit.
Test plan
build-clang/bin/binaryen-lit test/lit/validation/fp16-unary.wast -vbuild-clang/bin/binaryen-lit test/lit/validation/fp16-memory.wast -vbuild-clang/bin/binaryen-lit test/lit/validation -v./check.py --binaryen-bin build-clang/bin validator